feat: Externalize ZTVP charts: cert-manager#2
Open
minmzzhang wants to merge 1 commit intovalidatedpatterns:mainfrom
Open
feat: Externalize ZTVP charts: cert-manager#2minmzzhang wants to merge 1 commit intovalidatedpatterns:mainfrom
minmzzhang wants to merge 1 commit intovalidatedpatterns:mainfrom
Conversation
minmzzhang
force-pushed
the
externalizing-charts
branch
11 times, most recently
from
357ae25 to
dcc7c45
Compare
Contributor
|
Please also run "make helm-docs". Any durable changes to the README should go in the .gotmpl file. We've started putting release notes there, see https://github.com/validatedpatterns/openshift-data-foundations-chart/blob/main/README.md.gotmpl for an example |
mhjacks
requested changes
Feb 11, 2026
Chart.yaml
Outdated
| # This is the version number of the application being deployed. This version | ||
| # number should be incremented each time you make changes to the application. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "1.16.0" |
Contributor
There was a problem hiding this comment.
Are we particular about the appVersion here?
Author
There was a problem hiding this comment.
This is from the original charts/certmanager, it's not harmful but informative metadata to be there IMHO
minmzzhang
force-pushed
the
externalizing-charts
branch
4 times, most recently
from
50b9860 to
f9c34e4
Compare
Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
externalizing-charts
branch
from
f9c34e4 to
884c3be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Externalize chart from layered-zero-trust: add templates and values from
charts/certmanager/.